2.9 KiB
2.9 KiB
TODO - Issues Found from Code Quality and E2E Tests
Code Formatting Issues (deno task check)
Critical Issues
- 5 files not formatted properly - Need to run
deno fmtto fix formatting - Files affected:
routes/tenant/messages/index.tsx- Import order and formatting issuesroutes/tenant/settings/index.tsx- Function definition formatting and indentationservices/messageService.ts- Import order issues- Additional files with formatting problems (truncated output)
Specific Formatting Problems
- Import Statement Order - Multiple files have incorrect import ordering
- Function Definition Formatting - Functions not properly formatted according to Deno standards
- Indentation Issues - Inconsistent indentation in JSX components
- Line Break Issues - Missing or extra line breaks in various files
E2E Test Failures (deno task e2e)
Failed Tests
-
reminders.spec.ts:4 - "landlord can send reminder and tenant receives it"
- Error: Element with role "heading" and name matching /messages/i not found
- Expected: Messages heading should be visible
- Status: Timeout after 5000ms
-
tenant-dashboard.spec.ts:50 - "tenant messages list shows landlord communication"
- Error: Element with role "heading" and name matching /messages/i not found
- Expected: Messages heading should be visible
- Status: Timeout after 5000ms
Test Infrastructure Issues
- Static File Serving Error: Server crashes when trying to serve static files
- Error: "Failed to read directory: No such file or directory (os error 2)"
- Path:
/Users/nanderson/nathanAndrinoid/cyberhybridhub.com/static - Impact: Tests failing due to missing static assets
Root Cause Analysis
- Both failed tests are looking for a "Messages" heading that doesn't exist
- This suggests either:
- The messages page/component is not rendering properly
- The heading text or role attributes are incorrect
- The navigation to messages page is failing
Priority Actions
High Priority
- Fix static file serving - Create missing
/staticdirectory or fix configuration - Investigate messages page - Check why messages heading is not rendering
- Run code formatting - Execute
deno fmtto fix all formatting issues
Medium Priority
- Review test expectations - Verify if test assertions match actual UI
- Check navigation flow - Ensure users can properly navigate to messages
- Fix import statements - Correct import order in affected files
Low Priority
- Code style consistency - Ensure all files follow consistent formatting
- Add error handling - Improve error handling for missing static files
Next Steps
- Create
/staticdirectory if missing - Run
deno fmtto fix formatting - Debug messages page rendering issue
- Re-run tests to verify fixes
- Address any remaining test failures