76 lines
2.1 KiB
Markdown
76 lines
2.1 KiB
Markdown
# TODO - Deno Check Errors
|
|
|
|
## TypeScript Errors Found (34 total)
|
|
|
|
### Primary Issue: Missing Playwright Dependency
|
|
|
|
Multiple files have
|
|
`TS2307: Import "@playwright/test" not a dependency and not in import map`
|
|
|
|
**Affected Files:**
|
|
|
|
- tests/e2e/document-api.spec.ts:1:36
|
|
- tests/e2e/documents.spec.ts:1:36
|
|
- tests/e2e/financial-api.spec.ts:1:36
|
|
- tests/e2e/financial-ui.spec.ts:1:36
|
|
- tests/e2e/guest-home.spec.ts:1:36
|
|
- tests/e2e/helpers.ts:1:36
|
|
- tests/e2e/invite-tenant.spec.ts:1:36
|
|
- tests/e2e/landlord-dashboard.spec.ts:1:36
|
|
- tests/e2e/landlord-messages.spec.ts:1:36
|
|
- tests/e2e/landlord-onboarding.spec.ts:1:36
|
|
- tests/e2e/multi-property.spec.ts:1:36
|
|
- tests/e2e/onboarding.spec.ts:1:36
|
|
- tests/e2e/reminders.spec.ts:1:36
|
|
- tests/e2e/tenant-dashboard.spec.ts:1:36
|
|
|
|
### Secondary Issue: Implicit Any Types
|
|
|
|
`TS7031: Binding element` errors for untyped parameters:
|
|
|
|
**Files with untyped `page` parameter:**
|
|
|
|
- tests/e2e/documents.spec.ts (lines 4:61, 29:63)
|
|
- tests/e2e/financial-ui.spec.ts (lines 4:60, 19:71)
|
|
- tests/e2e/guest-home.spec.ts (lines 4:26, 8:62, 24:58)
|
|
- tests/e2e/tenant-dashboard.spec.ts (lines 4:68, 18:67, 31:58, 50:68, 70:62)
|
|
|
|
**Files with untyped `request` parameter:**
|
|
|
|
- tests/e2e/document-api.spec.ts (lines 4:75, 70:78)
|
|
- tests/e2e/financial-api.spec.ts (lines 4:68, 19:59, 40:65, 76:66)
|
|
|
|
**Files with other untyped parameters:**
|
|
|
|
- tests/e2e/helpers.ts:7:8 - `({ now })` parameter
|
|
- tests/e2e/helpers.ts:82:31 - `({ id })` parameter
|
|
|
|
## Required Actions
|
|
|
|
1. **Install Playwright dependency:**
|
|
```bash
|
|
deno add jsr:@playwright/test
|
|
```
|
|
|
|
2. **Add proper TypeScript types for Playwright test parameters:**
|
|
- Import types from `@playwright/test`
|
|
- Type the `page`, `request`, `now`, and `id` parameters
|
|
|
|
3. **Example fix pattern:**
|
|
```typescript
|
|
import { Page, Request, TestInfo } from "@playwright/test";
|
|
|
|
test("example test", async ({ page }: { page: Page }) => {
|
|
// test code
|
|
});
|
|
|
|
test("api test", async ({ request }: { request: Request }) => {
|
|
// test code
|
|
});
|
|
```
|
|
|
|
4. **Run deno check again after fixes to verify all errors resolved:**
|
|
```bash
|
|
deno check 2>&1 | head -c 5000
|
|
```
|